Sanitize version num from string to int by removing non-numeric characters #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an issue when I was trying to initialize the
Dataverseinstance for borealisdata.ca (also (https://demo.borealisdata.ca/).When I try to run this code:
The error message:
The reason is that there is a leading
vfor the major version number in Borealis:{"status":"OK","data":{"version":"v6.4.1-SP","build":null}}This PR sanitizes the version number, ensuring the number can be changed from
strtoint, and can then perform the check.Not sure this can be accepted! Because it's likely more a signle Dataverse instance issue!