test: shared sdk wrapper other platforms #5085
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
force-pushed
the
armcknight/test/share-sdk-wrapper
branch
from
78e25e9 to
3112778
Compare
armcknight
commented
Apr 12, 2025
|
|
||
| options.enableAutoSessionTracking = !SentrySDKOverrides.Performance.disableSessionTracking.boolValue | ||
| if let sessionTrackingIntervalMillis = env["--io.sentry.sessionTrackingIntervalMillis"] { | ||
| options.sessionTrackingIntervalMillis = UInt((sessionTrackingIntervalMillis as NSString).integerValue) | ||
| } else { | ||
| options.sessionTrackingIntervalMillis = 5_000 |
There was a problem hiding this comment.
This wasn't set for many of the sample apps as the default
| #endif // os(iOS) || os(tvOS) || targetEnvironment(macCatalyst) || os(visionOS) | ||
|
|
||
| #if os(macOS) | ||
| options.enableUncaughtNSExceptionReporting = true |
There was a problem hiding this comment.
This was only set for macOS-SwiftUI but not macOS-Swift
| return scope | ||
| } | ||
|
|
||
| options.experimental.enableFileManagerSwizzling = !args.contains("--disable-filemanager-swizzling") |
There was a problem hiding this comment.
This launch arg introduced in #4634 wasn't actually configured in any of our shared schemas, I shared it in the upstream PR at https://github.com/getsentry/sentry-cocoa/pull/5076/files#diff-384a7a6c421086af40fa69500d57db0f5122e16c6c2753bf6bbf60447e2a3c06R105 so now all sample apps can use it
armcknight
force-pushed
the
armcknight/test/share-sdk-wrapper
branch
from
3112778 to
783f991
Compare
armcknight
force-pushed
the
armcknight/test/shared-sdk-wrapper-other-platforms
branch
from
22f774b to
4933865
Compare
…/shared-sdk-wrapper-other-platforms
…/shared-sdk-wrapper-other-platforms
…/shared-sdk-wrapper-other-platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #5076 and #5077, switch the remaining sample apps implemented in Swift on other platforms to use the shared SDK wrapper.
#skip-changelog