Fix Spring 7 and Spring Boot 4 modules #4602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 4, 2025
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Fix Spring 7 and Spring Boot 4 modules ([#4602](https://github.com/getsentry/sentry-java/pull/4602))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
adinauer
force-pushed
the
08-04-fix_spring_7_and_spring_boot_4_modules
branch
from
c7988b5 to
a5d68ca
Compare
7 tasks
adinauer
force-pushed
the
08-04-fix_spring_7_and_spring_boot_4_modules
branch
from
a5d68ca to
7887992
Compare
adinauer
force-pushed
the
08-04-add_new_modules_for_spring_7_and_spring_boot_4
branch
from
e7a97e5 to
3ec789b
Compare
This was referenced Aug 7, 2025
lcian
approved these changes
Aug 8, 2025
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
adinauer
merged commit ddeada2
into
08-04-add_new_modules_for_spring_7_and_spring_boot_4
33 of 70 checks passed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -111,7 +111,7 @@ private void configureScope( | |||
| final @NotNull IScopes scopes, final @NotNull HttpServletRequest request) { | |||
| if (scopes.getOptions().isSendDefaultPii() | |||
| && qualifiesForCaching(request, scopes.getOptions().getMaxRequestBodySize())) { | |||
| return new ContentCachingRequestWrapper(request); | |||
| return new ContentCachingRequestWrapper(request, 0); | |||
There was a problem hiding this comment.
Bug: Request Body Caching Limit Set Incorrectly
The ContentCachingRequestWrapper constructor now hardcodes 0 as the cache limit. This likely disables or severely restricts request body caching, overriding the intended behavior determined by qualifiesForCaching and the maxRequestBodySize configuration (e.g., 1000 bytes for SMALL, 10000 for MEDIUM).
adinauer
added a commit
that referenced
this pull request
Aug 26, 2025
* Add new modules for Spring 7 and Spring Boot 4 * Fix Spring 7 and Spring Boot 4 modules (#4602) * Attempt to fix kotlin 2.2 issue (#4603) * Fix Spring 7 and Spring Boot 4 modules * Attempt to fix kotlin 2.2 issue * Second attempt to fix Kotlin 2.2 (#4610) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat (#4613) --------- Co-authored-by: Sentry Github Bot <[email protected]> * Address compose-related issues * Fix tests for Spring 7 and Spring Boot 4 (#4614) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat * Fix tests for Spring 7 and Spring Boot 4 * Move Spring 7 and Spring Boot 4 packages (#4615) * Move Spring 7 and Spring Boot 4 packages * Fix class not found due to OTel not supporting spring boot 4 yet (#4616) * Format code * some fixes * change kotlin 1.8 to 1.9 and some cleanup * ignore warnings about api level that is not relevant * fix optional dependencies in SentryAutoConfiguration * Update trace origin * Remove duplicate e2e test config * Update Strings for Spring 7 and Spring Boot 4 * Disable Spring Boot 4 agentless e2e tests for now --------- Co-authored-by: Sentry Github Bot <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: markushi <[email protected]> * changelog * fix ci * add ignored span origins for Spring 7 and Spring Boot 4 * move changelog * Example how to fix version mismatch (#4642) * Fix ignored span origin * move changelog --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: markushi <[email protected]> Co-authored-by: Alex Alderman Webb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
.apifiles💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps