-
-
Notifications
You must be signed in to change notification settings - Fork 454
Fix tests for Spring 7 and Spring Boot 4 #4614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 08-04-attempt_to_fix_kotlin_2.2_issue
Are you sure you want to change the base?
Fix tests for Spring 7 and Spring Boot 4 #4614
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Fix tests for Spring 7 and Spring Boot 4 ([#4614](https://github.com/getsentry/sentry-java/pull/4614)) If none of the above apply, you can opt out of this check by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test changes look good to me.
It seems that this unfortunately got intertwined with the Kotlin fixes. I've pointed out the places where the build files look odd, so let's please remember to address those before merging.
build.gradle.kts
Outdated
alias(libs.plugins.kotlin.multiplatform) apply false | ||
alias(libs.plugins.kotlin.jvm) apply false | ||
// alias(libs.plugins.kotlin.jvm.spring7) apply false | ||
alias(libs.plugins.kotlin.spring) apply false | ||
// alias(libs.plugins.kotlin.spring7) apply false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to update?
@@ -5,8 +5,10 @@ import org.springframework.boot.gradle.plugin.SpringBootPlugin | |||
plugins { | |||
`java-library` | |||
id("io.sentry.javadoc") | |||
kotlin("jvm") | |||
// alias(libs.plugins.kotlin.jvm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// alias(libs.plugins.kotlin.jvm) |
@@ -5,7 +5,8 @@ import org.gradle.internal.extensions.stdlib.capitalized | |||
|
|||
plugins { | |||
id("com.android.application") | |||
kotlin("android") | |||
alias(libs.plugins.kotlin.android) | |||
// alias(libs.plugins.kotlin.compose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// alias(libs.plugins.kotlin.compose) |
@@ -4,7 +4,8 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompilationTask | |||
|
|||
plugins { | |||
id("com.android.library") | |||
kotlin("android") | |||
alias(libs.plugins.kotlin.android) | |||
// alias(libs.plugins.kotlin.compose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// alias(libs.plugins.kotlin.compose) |
@@ -3,7 +3,8 @@ import net.ltgt.gradle.errorprone.errorprone | |||
|
|||
plugins { | |||
id("com.android.application") | |||
kotlin("android") | |||
alias(libs.plugins.kotlin.android) | |||
// alias(libs.plugins.kotlin.compose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// alias(libs.plugins.kotlin.compose) |
@@ -2,7 +2,8 @@ import io.gitlab.arturbosch.detekt.Detekt | |||
|
|||
plugins { | |||
id("com.android.application") | |||
kotlin("android") | |||
alias(libs.plugins.kotlin.android) | |||
// alias(libs.plugins.kotlin.compose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// alias(libs.plugins.kotlin.compose) |
* Move Spring 7 and Spring Boot 4 packages * Fix class not found due to OTel not supporting spring boot 4 yet (#4616)
…ests_for_spring_7_and_spring_boot_4
Performance metrics 🚀
|
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps