-
-
Notifications
You must be signed in to change notification settings - Fork 455
Add support for w3c traceparent header #4671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
674d437 | 355.28 ms | 504.18 ms | 148.90 ms |
ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
674d437 | 1.58 MiB | 2.10 MiB | 530.94 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
Previous results on branch: feat/w3c-trace-header
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
065c8b3 | 401.33 ms | 456.09 ms | 54.76 ms |
032a83e | 372.32 ms | 420.27 ms | 47.95 ms |
3b2c046 | 366.37 ms | 455.58 ms | 89.22 ms |
88b4829 | 484.45 ms | 577.06 ms | 92.61 ms |
2149101 | 353.42 ms | 411.27 ms | 57.84 ms |
7e94d68 | 372.78 ms | 450.06 ms | 77.28 ms |
6aed485 | 373.33 ms | 439.26 ms | 65.93 ms |
2ee7842 | 383.95 ms | 440.12 ms | 56.17 ms |
80398b6 | 390.02 ms | 441.79 ms | 51.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
065c8b3 | 1.58 MiB | 2.10 MiB | 533.39 KiB |
032a83e | 1.58 MiB | 2.10 MiB | 533.16 KiB |
3b2c046 | 1.58 MiB | 2.10 MiB | 533.43 KiB |
88b4829 | 1.58 MiB | 2.10 MiB | 533.42 KiB |
2149101 | 1.58 MiB | 2.10 MiB | 533.43 KiB |
7e94d68 | 1.58 MiB | 2.10 MiB | 533.16 KiB |
6aed485 | 1.58 MiB | 2.10 MiB | 533.39 KiB |
2ee7842 | 1.58 MiB | 2.10 MiB | 533.38 KiB |
80398b6 | 1.58 MiB | 2.10 MiB | 533.39 KiB |
Would it make sense to add unit tests for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
I'm wondering if we should take this option into account in OtelSentryPropagator::inject
too.
On one hand, it would make things more consistent.
On the other, OTEL users can just use the W3C propagator which will both extract from incoming requests and inject into outgoing ones. We wouldn't want to conflict with it. Also our approach would only inject which might not be what users expect.
So, overall I think the current approach to exclude our OTEL propagator is fine.
@markushi after discussing this with @adinauer we think it's better to add this to the |
We just discussed in daily. Adding support for traceparent on JVM side (Desktop / Backend) isn't a priority at the moment. We can also skip it for now if you prefer. |
📜 Description
Implements support for adding the w3c traceparent HTTP header.
Based on https://develop.sentry.dev/sdk/telemetry/traces and https://develop.sentry.dev/sdk/telemetry/traces/distributed-tracing
💡 Motivation and Context
Implements #4678
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps