Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue summary) Receive optional possible cause scores #84346

Merged

Conversation

kddubey
Copy link
Contributor

@kddubey kddubey commented Jan 30, 2025

schema from here

@kddubey kddubey requested a review from roaga January 30, 2025 22:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 30, 2025
@kddubey kddubey merged commit e37eb2e into master Jan 31, 2025
51 checks passed
@kddubey kddubey deleted the kddubey/issue-summary/thresholds-possible-cause-backend branch January 31, 2025 20:31
kddubey added a commit that referenced this pull request Jan 31, 2025
…84349)

## Background

`possible_cause_confidence` increases when there's less speculation
(which correlates w/ slightly more accurate causes)

`possible_cause_novelty` increases when there's more novelty / less
redundancy wrt `whats_wrong`

thresholds led to 50% of possible causes getting dropped on our autofix
sentry issues ([notebook
here](https://github.com/getsentry/data-analysis/blob/main/autofix/issue_summary/issue_summary_confidence.ipynb))

## Backend changes

corresponding backend change to sentry: #84346

corresponding backend change to seer:
getsentry/seer#1788

without the sentry backend change (there are no `data.scores`), default
to current behavior: always show possible cause


![before](https://github.com/user-attachments/assets/9f632a94-690b-4602-bdea-cbd2b95824b0)

with the change, only show it if both scores are greater than the
threshold


![after](https://github.com/user-attachments/assets/0b1e84af-cc0b-4d0a-8106-58cc615ea602)

(note: this example is actually considered novel and confident-enough. I
hardcoded the threshold to test the behavior)
andrewshie-sentry pushed a commit that referenced this pull request Feb 5, 2025
<!-- Describe your PR here. -->
schema from
[here](https://github.com/getsentry/seer/blob/696452da11113cec497029bfb92339d7660ead8d/src/seer/automation/summarize/models.py#L17-L28)
<!--

  Sentry employees and contractors can delete or ignore the following.

-->
andrewshie-sentry pushed a commit that referenced this pull request Feb 5, 2025
…84349)

## Background

`possible_cause_confidence` increases when there's less speculation
(which correlates w/ slightly more accurate causes)

`possible_cause_novelty` increases when there's more novelty / less
redundancy wrt `whats_wrong`

thresholds led to 50% of possible causes getting dropped on our autofix
sentry issues ([notebook
here](https://github.com/getsentry/data-analysis/blob/main/autofix/issue_summary/issue_summary_confidence.ipynb))

## Backend changes

corresponding backend change to sentry: #84346

corresponding backend change to seer:
getsentry/seer#1788

without the sentry backend change (there are no `data.scores`), default
to current behavior: always show possible cause


![before](https://github.com/user-attachments/assets/9f632a94-690b-4602-bdea-cbd2b95824b0)

with the change, only show it if both scores are greater than the
threshold


![after](https://github.com/user-attachments/assets/0b1e84af-cc0b-4d0a-8106-58cc615ea602)

(note: this example is actually considered novel and confident-enough. I
hardcoded the threshold to test the behavior)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants