feat(issue summary) Only show possible cause if confident and novel #84349
+63
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #84349 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 9601 9601
Lines 543278 543278
Branches 21286 21286
=======================================
Hits 476034 476034
Misses 66891 66891
Partials 353 353 |
roaga
reviewed
Jan 30, 2025
kddubey
commented
Jan 30, 2025
| title: t('Possible cause'), | ||
| insight: data?.possibleCause, | ||
| icon: <IconFocus size="sm" />, | ||
| showWhenLoading: false, |
There was a problem hiding this comment.
@roaga double-checking that changing showWhenLoading from true to false makes sense?
There was a problem hiding this comment.
yeah that makes sense, but actually now that I see this, I'm not sure about the logic. You need the scores from the generated summary to determine the loading logic, but you don't have the scores until loading is done. Are you sure this works correctly when you tested it locally?
…ry/thresholds-possible-cause-frontend
|
no review notes, but this is awesome. great work |
roaga
approved these changes
Jan 31, 2025
| title: t('Possible cause'), | ||
| insight: data?.possibleCause, | ||
| icon: <IconFocus size="sm" />, | ||
| showWhenLoading: false, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
possible_cause_confidenceincreases when there's less speculation (which correlates w/ slightly more accurate causes)possible_cause_noveltyincreases when there's more novelty / less redundancy wrtwhats_wrongthresholds led to 50% of possible causes getting dropped on our autofix sentry issues (notebook here)
Backend changes
corresponding backend change to sentry: #84346
corresponding backend change to seer: getsentry/seer#1788
without the sentry backend change (there are no
data.scores), default to current behavior: always show possible causewith the change, only show it if both scores are greater than the threshold
(note: this example is actually considered novel and confident-enough. I hardcoded the threshold to test the behavior)