ref(gocd): Add a crashloop monitor to deploys #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a crashloop monitor to the S4S deploy to ensure that the changes at least keep the pods stable.
volokluev
approved these changes
Jun 6, 2024
| @@ -1 +1,8 @@ | |||
| #!/bin/bash | |||
|
|
|||
| /devinfra/scripts/checks/datadog/monitor_status.py --dry-run=true \ | |||
There was a problem hiding this comment.
what does dry-run=true do here?
There was a problem hiding this comment.
Oh hmm it means that on failure it doesn't actually raise an alert. Which is weird, because I copied this from the SaaS health check script. So I guess we're not actually checking the monitors there either.
There was a problem hiding this comment.
I'll look at the monitors involved and see. I think the answer is yes.
enochtangg
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a crashloop monitor to the S4S deploy to ensure that the changes at least keep the pods stable.