Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(gocd): Add a crashloop monitor to deploys #6006

Closed
wants to merge 3 commits into from
Closed

ref(gocd): Add a crashloop monitor to deploys #6006

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e328c98
ref(gocd): Add a crashloop monitor to deploys
evanh Jun 6, 2024
cbabc18
saas too
evanh Jun 6, 2024
631a988
remove dryrun
evanh Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions gocd/templates/bash/s4s-ddog-health-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
#!/bin/bash

/devinfra/scripts/checks/datadog/monitor_status.py --dry-run=true \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does dry-run=true do here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hmm it means that on failure it doesn't actually raise an alert. Which is weird, because I copied this from the SaaS health check script. So I guess we're not actually checking the monitors there either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we... check it? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at the monitors involved and see. I think the answer is yes.

146517092


# Above monitor IDs map to following monitors respectively:
# Snuba Pods Crashlooping in {{sentry_region.name}}
4 changes: 3 additions & 1 deletion gocd/templates/bash/saas-ddog-health-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

/devinfra/scripts/checks/datadog/monitor_status.py --dry-run=true \
113296727 \
42722121
42722121 \
146517092


# Above monitor IDs map to following monitors respectively:
# Snuba - SLO - High API error rate
# Snuba - Too many restarts on Snuba pods
# Snuba Pods Crashlooping in {{sentry_region.name}}
Loading