Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace redis library in redis store implementation #129

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AlexeyBelezeko
Copy link

This pull request replaces redigo with redis-go in Redis store implementation. Such change provides additional flexibility by using Redis client interface to construct a new store, which adds the possibility to use RedisCluster or RedisMock.

@llmgo
Copy link

llmgo commented Oct 18, 2021

This is a good suggestion

@rubensayshi
Copy link
Contributor

rubensayshi commented Jan 30, 2022

@appleboy this just got bumped up quite a bit in priority as redigo deprecated the version which you're using and it's breaking any go list actions ...

go list -u -m -json all
go list -m: github.com/gomodule/[email protected]+incompatible: retracted by module author: Old development version not maintained or published.
go list -m: github.com/gin-contrib/[email protected] requires
	github.com/gomodule/[email protected]+incompatible: missing go.sum entry; to add it:
	go mod download github.com/gomodule/redigo

I opened a fresh PR which is rebased and uses the latest versions: #148

@fgm
Copy link

fgm commented Feb 17, 2023

Redigo has a maintained branch in the 1.8.x series (currently 1.8.9), updated not long after this issue. Probably better to stay on it and just depend on the live version (1.8.9) instead of the older pre-module deprecated one (2.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants