Replace redis library in redis store implementation #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rubensayshi. I'm totally ok. Hope you will be lucky and this MR will be merged. |
|
Came here looking for this. |
|
Redigo has a maintained branch in the 1.8.x series (currently 1.8.9), updated not long after this issue. Probably better to stay on it and just depend on the live version (1.8.9) instead of the older pre-module deprecated one (2.0.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redigo deprecated the version which you're using and it's breaking any
go listactions ...I've taken the PR by @AlexeyBelezeko (#129) and rebased it and bumped the redis depedencies to v8. Credit goes to him for all the work so I've left the commit author on his name if he's okay with that as well ;)