JS: QL-side type/name resolution for TypeScript and JSDoc #19078
+1,496
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
asgerf
force-pushed
the
js/name-resolution
branch
from
cee75ae to
fa3e5ed
Compare
| } | ||
|
|
||
| /** Helps track flow from a particular set of source nodes. */ | ||
| module Track<nodeSig/1 isSource> { |
Check warning
Code scanning / CodeQL
Dead code Warning
| target = cls.getConstructor().getBody() | ||
| ) | ||
| or | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackFunctionValue(target)) |
Check warning
Code scanning / CodeQL
Redundant cast Warning
| or | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackFunctionValue(target)) | ||
| or | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackFunctionType(target)) and |
Check warning
Code scanning / CodeQL
Redundant cast Warning
| ) | ||
| or | ||
| exists(InterfaceDefinition interface, CallSignature sig | | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackType(interface)) and |
Check warning
Code scanning / CodeQL
Redundant cast Warning
asgerf
force-pushed
the
js/name-resolution
branch
2 times, most recently
from
fe9b23d to
c07cc6e
Compare
This reverts commit 385e663.
Previously, ambient declarations were ignored during variable resolution in the extractor. However, this makes it difficult to implement name/type resolution in QL, since ambient declaration can affect type checking. Instead, the extractor's variable resolution no longer cares whether a given declaration is ambient. The original behaviour was not particularly important to preserve since 'declare' can only appear at the top-level or inside 'namespace' declarations.
Our DOM model doesn't model 'document.implementation', and it seem we don't need to
asgerf
force-pushed
the
js/name-resolution
branch
from
2d928f2 to
3b395af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.