Switch to native arm builder + docker/metadata #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froozeify
changed the title
froozeify
force-pushed
the
ci-matrix-build-and-cache-update
branch
from
89259fd to
899c777
Compare
froozeify
changed the title
This was referenced Jan 8, 2026
froozeify
force-pushed
the
ci-matrix-build-and-cache-update
branch
from
6670b53 to
1571f44
Compare
cedric-anne
reviewed
Jan 13, 2026
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
IMHO, we should keep only the .github/workflows/_glpi-build.yml and trigger calls directly from GLPI.
Also, maybe we could add a on.push event with a step that uses default inputs, to trigger the ci build (without pushing images) when the workflow is updated.
cedric-anne
reviewed
Jan 14, 2026
glpi/files/opt/glpi/entrypoint.sh
Outdated
Comment on lines
4
to
7
| # Source GLPI environment variables (includes GLPI_MARKETPLACE_DIR detected at build time) | ||
| if [ -f /etc/glpi_env ]; then | ||
| export $(cat /etc/glpi_env | xargs) | ||
| fi |
Member
There was a problem hiding this comment.
The issue with this is that it will erase any custom value defined by the admin.
We could decide to not support it if we do not find a better solution.
Member
Author
There was a problem hiding this comment.
I didn't find any cleaner way to support both 10 and 11 at the build time. I guess that's why it was in the set variable step before.
I could rollback this commit and let it in the set variable step
Add a `on.push/pr` to trigger the ci build (without pushing images) when the workflow is updated
froozeify
force-pushed
the
ci-matrix-build-and-cache-update
branch
from
0d9b5d2 to
07ca706
Compare
cedric-anne
reviewed
Jan 14, 2026
cedric-anne
reviewed
Jan 15, 2026
cedric-anne
reviewed
Jan 15, 2026
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
cedric-anne
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modifications are based on docker recommendation
Native arm runner are available for free github project (so no problem for glpi-project/docker-images) or for paid enterprise plan