Adjust milestone sort order for due date. Non due date milestone will be considered after all due date milestone #35200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be considered after all due date milestone
GiteaBot
added
the
lgtm/need 2
|
I don't think the code reads right. The |
|
6543
approved these changes
Aug 29, 2025
GiteaBot
added
lgtm/need 1
Well, I regretted that I approved 32339 ..... and I think we shouldn't add more patches. If you search "deadline_unix" in the code base, you can see there are more places using it for comparing and sorting. So the correct fix should be introducing a very large magic unix timestamp for "no due date", but never use it as a real date/time struct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35194
Related to #32339