fix VariationAttributes type location #39
Conversation
|
@spiegel-im-spiegel , please review this tiny and straightforward PR when you have a chance |
| } | ||
| Offers *struct { | ||
| VariationAttributes []VariationAttribute `json:",omitempty"` |
There was a problem hiding this comment.
It looks like the outer level member is VariationSummary.
| @@ -182,9 +182,9 @@ type Item struct { | |||
| Currency string | |||
| } | |||
| } `json:",omitempty"` | |||
| VariationAttributes []VariationAttribute `json:",omitempty"` | |||
There was a problem hiding this comment.
This member needs to stay. Their schema doesn't include it, but glance at the sample responses in the documentation. It includes it there and I'm able to get information by testing locally as well.
There was a problem hiding this comment.
Yeah, VariationAttributes is under the VariationsResult.Items[i] and not under VariationsResult.Items[i].ItemInfo in the sample response
|
Disregard comments. This looks good to me. |
|
Sorry for the late response. I’ve merged the request you sent. Thank you. |
|
Thank you @spiegel-im-spiegel ! Have a good one! |
Hey mate!
Thanks for sharing this SDK - it is very useful as I don't need to duplicate all the code for interacting with Amazon PA API in my project.
However, I've noted one issue that blocks me from getting VariationAttributes data
q := query.NewGetVariations( client.Marketplace(), client.PartnerTag(), client.PartnerType(), ).ASIN(productID). EnableImages(). EnableItemInfo(). EnableOffers(). EnableVariationSummary(). ParentASIN()I believe the issue is that the entity/entity.go type is not compatible with Amazon PA API response structure.
Current type VariationAttributes type location:
Item.ItemInfo.VariationAttributes
GetVariation operation VariationAttributes type location:
Item.VariationAttributes
Please, see:
https://webservices.amazon.com/paapi5/documentation/get-variations.html