Skip to content

fix VariationAttributes type location #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
Merged

fix VariationAttributes type location #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions entity/entity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@ type Item struct {
Currency string
}
} `json:",omitempty"`
VariationAttributes []VariationAttribute `json:",omitempty"`
Copy link
Contributor

@Oakes6 Oakes6 Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This member needs to stay. Their schema doesn't include it, but glance at the sample responses in the documentation. It includes it there and I'm able to get information by testing locally as well.

Copy link
Author

@kvydiuk kvydiuk Aug 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, VariationAttributes is under the VariationsResult.Items[i] and not under VariationsResult.Items[i].ItemInfo in the sample response
Screenshot 2025-08-30 at 9 54 38 pm

}
Offers *struct {
VariationAttributes []VariationAttribute `json:",omitempty"`
Copy link
Contributor

@Oakes6 Oakes6 Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the outer level member is VariationSummary.

Offers *struct {
Listings *[]struct {
Availability *struct {
MaxOrderQuantity int
Expand Down
Loading