Make build build again? II: The Wrath of CLI #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evs-chris I fixed the hang in gobble. If my PR is merged, you won't need the |
Rich-Harris
added a commit
that referenced
this pull request
Apr 22, 2015
Make build build again? II: The Wrath of CLI
|
Ah, this is great sleuthing, thanks both. I removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the complement to gobblejs/gobble#49.
I wasn't getting any build output (code or log messages) and I tracked it back here to listening to the exported gobblefile node rather than the build task. I'm not 1000% sure that this is correct, particularly because it required a
process.exit(0)in the completion handler where there was none before.