Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Fix order of editor features #98988

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Nov 9, 2024

Order was broken after adding Game View

The new entry in the enum was added earlier at first, but was moved to the end to preserve compatibility, the associated strings were missed in the process

Regression from:


Order was broken after adding `Game View`
@YeldhamDev
Copy link
Member

A shame that this will break the pattern of ordering them the same way they appear in the editor itself, which is why I broke compatibility at first. Maybe something to remember and adjust in Godot 5.

@Mickeon
Copy link
Contributor

Mickeon commented Nov 10, 2024

One could add a TODO to do exactly that next to these strings? It's sure annoying but not that big of a deal, though.

@Repiteo Repiteo merged commit 5d7a7c0 into godotengine:master Nov 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Thanks!

@AThousandShips AThousandShips deleted the fix_game_feature branch November 10, 2024 19:39
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants