feat: internalize extensions to Color
#386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initializers `init(rgba:)` and `init(light:dark:)`, introduced in gonzalezreal#168 are very useful, but should be `internal`. Marked as `public`, these functions are liable to cause conflicts with other packages. The potential for conflict is heightened by the functions' utility and the intuitive name.
cweider
force-pushed
the
internalize-extensions
branch
from
35c104a to
86b7b05
Compare
cweider
changed the title
ColorColor
cweider
commented
Feb 13, 2025
| @@ -16,7 +16,7 @@ extension Color { | |||
| /// - Parameters: | |||
| /// - light: The light appearance color value. | |||
| /// - dark: The dark appearance color value. | |||
| public init(light: @escaping @autoclosure () -> Color, dark: @escaping @autoclosure () -> Color) { | |||
There was a problem hiding this comment.
Aside: AppKit and UIKit are almost certainly supposed to specify that dynamicProvider needs to be Sendable (see: FB16492911 & FB16492913).
@Sendable would be good to add prior to adopting the Swift 6 runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this reviewing code in a project importing
swift-markdown-ui. The usage had no relation to Markdown. The method was used because it was there and it was useful. I’ve not encountered a real conflict, but #265 suggests that the risk of a conflict is not speculative.The initializers
init(rgba:)andinit(light:dark:), introduced in #168 are very useful, but should beinternal. Marked aspublic, these functions are liable to cause conflicts with other packages. The potential for conflict is heightened by the functions' utility and the intuitive name.Note: this breaks the public API; it requires a Major Version change