-
Notifications
You must be signed in to change notification settings - Fork 192
Add step parsing for each agent section #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/gcbrun exp -n mv -m vertex_ai_gemini-2-flash-chat -ag |
Thanks, this looks great! :) Here are a few thoughts on the UX:
These are just my initial impressions: Happy to hear what you think! |
So instead of
We use some variant of
to represent the following logs: Step 1:
<bash>
grep -rn 'janet_fiber(' /src/janet/
</bash>
...
<reason>
Find the definition of the `JanetFunction` type.
</reason>
<bash>
grep -rn 'typedef struct JanetFunction' /src/janet/
</bash>
<reason>
Examine how to create a JanetFunction. Looking for examples of its usage.
</reason>
<bash>
grep -rn 'JanetFunction' /src/janet/ | grep -v 'typedef struct JanetFunction'
</bash>
Step 2:
<bash>
grep -rn 'typedef struct JanetFunction' /src/janet/
</bash>
...
<bash>
grep -rn 'JanetFunction' /src/janet/ | grep -v 'typedef struct JanetFunction'
</bash>
...
<reason>
It appears that creating a `JanetFunction` directly is complex. Instead, I'll try to get a `JanetFunction` by creating a Janet function using `janet_wrap_cfunction`.
</reason>
<bash>
grep -rn 'janet_wrap_cfunction' /src/janet/
</bash>
...
Step 3:
<bash>
grep -rn 'janet_wrap_cfunction' /src/janet/
</bash>
<conclusion>
The fuzz target needs to initialize Janet, create a dummy C function, wrap it as a `Janet` value using `janet_wrap_cfunction`, create a `JanetFiber` with this value, call `janet_loop_fiber` with the fiber, and then deinitialize Janet. The build script doesn't need modification.
</conclusion> I think this can actually be made toggle-able, so that the user can decide whether they just want a high-level skim of the tools used or they want a more low-level preview of the collapsed content. |
/gcbrun exp -n mv -m vertex_ai_gemini-2-flash-chat -ag |
This PR adds step parsing for each agent section to transform the raw content at each step into a more human-readable format, with collapsible subsections containing a text preview of the chat prompt/response (first 50 words).
Preview