Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion from xml to json #843

Draft
wants to merge 4 commits into
base: exp-843
Choose a base branch
from

Conversation

nugget-cloud
Copy link

@nugget-cloud nugget-cloud commented Mar 8, 2025

#743
@DonggeLiu
Hello, I made some changes by removing the XML tags from all the prompts in the prompts directory. Could you please provide some feedback on whether I'm doing this correctly?

I attempted to run run_all_experiments.py, but I stopped midway because I was concerned it was making too many calls and that the API might be expensive.

Copy link

google-cla bot commented Mar 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nugget-cloud nugget-cloud changed the title conversion from xml to json #743 conversion from xml to json Mar 8, 2025
@nugget-cloud nugget-cloud changed the title #743 conversion from xml to json conversion from xml to json Mar 8, 2025
Copy link
Collaborator

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nugget-cloud.
Given this is an exploration work, we can start from some small experiments using agent-related templates (e.g., in prompts/agent, prompts/tool).
If they prove to be useful, we can extend the JSON structure to more prompts.

Some minor comments below:

@DonggeLiu
Copy link
Collaborator

I attempted to run run_all_experiments.py, but I stopped midway because I was concerned it was making too many calls and that the API might be expensive.

Yep, it will be expensive to run it locally.
We have PR experiments which runs it on our cloud and won't cost you anything.

However, PR experiments can only be run by the maintainer of this repo.
The simplest solution is:

  1. I create a new PR for us to run experiments (Done here: [DO NOT MERGE] Experiment PR for #843 #844).
  2. You rebase your PR on to the new experiment PR.
  3. I will merge your PR to run experiments from there.

For simplicity, let's revert the conflict files for now (we need to start with some small experiments using agent-related templates anyway) so that you don't have to repeatedly fixing them.
But you do have to solve the CLA error in CI.

@DonggeLiu DonggeLiu changed the base branch from main to exp-843 March 9, 2025 23:43
@nugget-cloud nugget-cloud force-pushed the issue-743-json-llm branch 2 times, most recently from 821989f to 8dfbb9f Compare March 12, 2025 12:35
@nugget-cloud
Copy link
Author

Hi , @DonggeLiu I signed the CLA but the error still persists , I am not sure what is the issue

@DonggeLiu
Copy link
Collaborator

Hi , @DonggeLiu I signed the CLA but the error still persists , I am not sure what is the issue

It's because of this:
image

image

@DonggeLiu DonggeLiu marked this pull request as draft March 24, 2025 00:48
@DonggeLiu
Copy link
Collaborator

Converting this to a draft for now, but please let me know when you are ready. @nugget-cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants