Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llm: Fix chat_llm for OpenAI model #902

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions llm_toolkit/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ def __init__(
self.temperature = temperature
self.temperature_list = temperature_list

# Preserve chat history for OpenAI
self.messages = []

def cloud_setup(self):
"""Runs Cloud specific-setup."""
# Only a subset of models need a cloud specific set up, so
Expand Down Expand Up @@ -275,14 +278,19 @@ def chat_llm(self, client: Any, prompt: prompts.Prompt) -> str:
logger.info('OpenAI does not allow temperature list: %s',
self.temperature_list)

self.messages.extend(prompt.get())

completion = self.with_retry_on_error(
lambda: client.chat.completions.create(messages=prompt.get(),
lambda: client.chat.completions.create(messages=self.messages,
model=self.name,
n=self.num_samples,
temperature=self.temperature),
[openai.OpenAIError])

return completion.choices[0].message.content
llm_response = completion.choices[0].message.content
self.messages.append({'role': 'assistant', 'content': llm_response})

return llm_response

def ask_llm(self, prompt: prompts.Prompt) -> str:
"""Queries LLM a single prompt and returns its response."""
Expand Down
3 changes: 2 additions & 1 deletion llm_toolkit/prompts.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def gettext(self) -> str:
"""Gets the final formatted prompt in plain text."""
result = ''
for item in self.get():
result = f'{result}\n{item.get("content", "")}'
result = (f'{result}\n{item.get("role", "Unknown")}:'
f'\n{item.get("content", "")}')

return result

Expand Down