feat: rewrite MCP server in Go #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow tools such as go build/install to know the name of the generated binary, and allow additional binaries in the future.
|
To make the migration easier for users I was hoping we could continue with our Python package and shove a platform-specific Go binary inside the package wheel, and use a tiny |
|
I think that can be a future PR, and I am not sure if it is really necessary either. If we can have easy instructions for installing the go binary then having a Python wrapper would just make things more complicated. |
Turns out that we need v1/ as a suffix, with the training slash, in the Incident URL for the client to work. I added both a cloud test that can be run locally to make sure everything works, as well as a unit test to test this specific issue.
csmarchbanks
approved these changes
Mar 12, 2025
List incidents and list datasources can use a lot more context than necessary when returning results. For dashboards use a custom struct that only returns a few fields. For incidents use the preview incident endpoint which returns a more concise format.
Limit the amount of data returned for list tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the existing Python implementation of the MCP server and adds a Go version.
The server can be started in either stdio or SSE mode based on the arguments. We still need to add some more flags for e.g. host and port of SSE mode.
Tools are factored into a separate package which can be imported from elsewhere. Using a similar method to the
mcp-golangSDK, we use reflection to inspect the types of the functions and generate tool definitions, used for thelist_toolsfunctionality.TODO:
Maybe later?