Fix windows tests

[heikki]

Includes things mentioned in #3.
I tested on mac & windows with node 0.10.33.

[phated]

Thanks! Is there any way to get this working without node-exit? In gulpjs/gulp#172 we decided not to use node-exit because it removes any process.on('exit') that have been added?

[heikki]

Hmm.. don't know yet. I'll check if I can find some alternative.

[heikki]

In gulpjs/gulp#172 we decided not to use node-exit because it removes any process.on('exit') that have been added?

Do you know how to reproduce that? All process.on('exit') s seem to work no matter where I put them. Also, time-grunt that @sindresorhus linked in that issue has comments suggesting that it may not be a problem anymore:

// crazy hack to work around stupid node-exit
// Can this be removed now that node-exit#4 has been resolved?
// https://github.com/cowboy/node-exit/issues/4
var originalExit = process.exit;

function exit(exitCode) {
  clearInterval(interval);
  process.emit('timegruntexit', exitCode);
  exit = function () {};
}

Testem includes similar solution as node-exit and that works too: https://github.com/airportyh/testem/blob/master/lib/clean_exit.js

[heikki]

It's still a problem & there's open issue too cowboy/node-exit#7
Btw. same code that fails with node-exit works with testem version.

https://gist.github.com/heikki/8b11d5bb918ecb9de6bf

[heikki]

Minimal exit tweak that makes tests pass and affects only windows:

function exit(code) {
  if (process.platform === 'win32' && process.stdout.bufferSize) {
    process.stdout.once('drain', function() {
      process.exit(code);
    });
    return;
  }
  process.exit(code);
}

[phated]

I'm good with this. Thanks!