Replace Rose::CodeEditor with Hds::CodeEditor
#2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zamoore
force-pushed
the
zamoore/HDS-4338/code-editor-upgrade
branch
from
e5bd84e to
fdb6a7a
Compare
zamoore
force-pushed
the
zamoore/HDS-4338/code-editor-upgrade
branch
from
b023237 to
1695997
Compare
zamoore
force-pushed
the
zamoore/HDS-4338/code-editor-upgrade
branch
from
105716b to
f338fd0
Compare
hashicc
requested changes
Apr 7, 2025
There was a problem hiding this comment.
A few questions and comments but this is a great update. Thanks for taking on this migration, it's always great to get another hds component in use, and the hds code editor looks much better!
JSON Static Credential Editor
Before
After
Ingress Worker Filter Editor
Before
After
ui/admin/tests/acceptance/credential-store/credentials/create-test.js
Outdated
Show resolved
Hide resolved
hashicc
reviewed
Apr 7, 2025
calcaide
dismissed stale reviews from lisbet-alvarez, cameronperera, and hashicc
via
0a5767b
- Remove CodeEditor 5 dependency
remove CodeMirror5 and replace existing editors with HDS::CodeEditor
changing code editor ✅ Closes: 0
self-review PR in the course of switching to new HDS code editor
remove jslint dependency as this is handled in the new code editor from HDS
Fix import bug caused by importing scss modules that no longer exist
zamoore
force-pushed
the
zamoore/HDS-4338/code-editor-upgrade
branch
from
d787e97 to
41d89a5
Compare
calcaide
approved these changes
Jul 16, 2025
ZedLi
approved these changes
Jul 16, 2025
11 tasks
9 tasks
cameronperera
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rose::CodeEditorwithHds::CodeEditorRose::CodeEditorcomponentCodeMirror 5dependency🎟️ Jira ticket
Screenshots
How to Test
Ensure all code editors in the app work as intended.
Checklist