Filter expired permissions from RAS Ga4gh Passports #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated logic to exclude expired permissions when processing Ga4gh Passports and their corresponding RasDbgapPermissions. Adjusted tests to validate the new filtering behavior, ensuring only non-expired permissions are included.
Moved date initialization out of the loop in `RASPassPortService` for better efficiency. Added a new test case to ensure expired permissions are filtered correctly during GA4GH passport conversion. Enhanced assertions to validate expected behavior.
Replaced `new Date().toInstant()` with `Instant.now()` for clearer and more concise timestamp generation. This simplifies the code and eliminates unnecessary intermediate objects while maintaining the same functionality. Updated corresponding test cases to reflect the changes.
Updated timestamp calculations to use seconds instead of milliseconds for consistency with expected formats. Adjusted related test cases to align with the updated logic.
Luke-Sikina
approved these changes
Feb 10, 2025
Gcolon021
commented
Feb 10, 2025
...edu/harvard/hms/dbmi/avillach/auth/service/impl/authentication/RASAuthenticationService.java
Outdated
Show resolved
Hide resolved
…lach/auth/service/impl/authentication/RASAuthenticationService.java
srpiatt
reviewed
Feb 10, 2025
...edu/harvard/hms/dbmi/avillach/auth/service/impl/authentication/RASAuthenticationService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logic to exclude expired permissions when processing Ga4gh Passports and their corresponding RasDbgapPermissions. Adjusted tests to validate the new filtering behavior, ensuring only non-expired permissions are included.