Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Page #47

Open
florian-papsdorf opened this issue Dec 2, 2020 · 5 comments
Open

Settings Page #47

florian-papsdorf opened this issue Dec 2, 2020 · 5 comments
Assignees
Labels

Comments

@florian-papsdorf
Copy link
Contributor

As a user I want to have one single page where I can edit all settings of the app.

@LinqLover
Copy link
Contributor

LinqLover commented Dec 3, 2020

Do we already have any settings or is this one still blocked?

Edit: Okay, I just found #48. Maybe it would be a good idea to reference these issues between each other so we don't loose the overview right now. 😅

This was referenced Dec 3, 2020
@florian-papsdorf florian-papsdorf added team-ε Issue assigned to Team 3 user-story labels Dec 7, 2020
@florian-papsdorf
Copy link
Contributor Author

Account Settings

@LinqLover LinqLover self-assigned this Jan 29, 2021
@LinqLover
Copy link
Contributor

LinqLover commented Jan 29, 2021

@florian-papsdorf A few questions:

  • Do I understand correctly that the views for user settings & profile edit should be merged?
  • There is no wireframe for changing the profile status or editing your name/email address. How should this look like? Redirect to another page? Also, does the status really belong to the settings? There is an option for this right on the dashboard, isn't it?
  • What should the eye button do?
  • Don't we need two input fields for each new handle, one for the platform and another one for the handle?

@LinqLover
Copy link
Contributor

Answers to the questions:

  • Do I understand correctly that the views for user settings & profile edit should be merged?

Yes

  • There is no wireframe for changing the profile status or editing your name/email address. How should this look like? Redirect to another page? Also, does the status really belong to the settings? There is an option for this right on the dashboard, isn't it?
  • Show a modal for name & email address when the edit button is clicked
  • Show a modal for choosing the user picture when the picture is clicked
  • We won't show or edit the status in the settings
  • What should the eye button do?
  • Hide or show the selected handle (new functionality!)
  • Don't we need two input fields for each new handle, one for the platform and another one for the handle?
  • Click on the question mark icon to get a modal for choosing the platform. When the form is submitted earlier, I think we should show the same modal, too.

@LinqLover
Copy link
Contributor

LinqLover commented Jan 29, 2021

Task structure:

  • Navbar: Remove link to Account Settings
  • New view/route (edit_profile) to change name, email address, and place from same controller (extract from user edit + account settings) (Separate edit profile page #157)
  • Remove email address from account settings view (Separate edit profile page #157)
  • Redesign user edit page:
    • show (dummy) picture
    • remove status editor
    • new CSS for page + social handles
    • add links to pages for changing password, deleting account, and logging out
    • add modals for editing name, email & place; editing social handle name; and choosing social handle platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants