Separate edit profile page #157
Conversation
Surprisingly, all the devise views saved in app/views/users were not actually used by devise because in devise.rb, config.scoped_views needed to be enabled first. After enabling it, it turned out that the users views were not configured with devise-bootstrap-views until now. So I regenerated them and as another consequence, it turned out that their corresponding i18n data were missing, too, so I also added devise-i18n-bootstrap to the Gemfile. Sigh ...
|
what is the difference between /edit and /edit_profile? is there a particular reason why they are not the same page? |
Yes, this is a part of #47, where we want to have a settings/profile page with an edit link which then leads you to the edit_profile page. Design will be worked out in another PR, but in the end the edit page will show up a modal dialog with the edit_profile form when requested. |
There was a problem hiding this comment.
Looks fine to me (except some minor things @felixauringer mentioned), thanks for the reconfiguration, must have been annoying ^^
|
@felixauringer Thanks for your review! All your suggestions but the first one refer to auto-generated code (I did not write it by hand ...). Do you think it is a good idea to change these auto-generations? Otherwise, I'd just leave it as-is. |
Hard for the same reason because then we would mix up the old and the new style and could not rely on the autogeneration any longer. But I promise you that I really did not make any manual changes in cf9060f :-) |
Fine for me, only some red tests to work on 👍 |
…s-portal into extract-edit-profile
Part of #47, see #47 (comment).
Tasks:
edit_profile) to change name, email address, and place from same controller (extract from user edit + account settings)In particular note the monster commit cf9060f and the relevant commit message ...