Synchronizer to prune all requests#677
Merged
HagarMeir merged 1 commit intohyperledger:mainfrom Mar 15, 2026
Merged
Conversation
HagarMeir
approved these changes
Mar 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the consensus synchronizer’s catch-up path to prune committed requests from the SmartBFT request pool even when the committed decision includes a config change, preventing config-related batches from leaving stale entries behind in the mempool.
Changes:
- Always deserialize the proposal payload into a request batch during sync, regardless of whether the decision includes a config block.
- Prune every request in the committed batch from the mempool, including config requests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tock-ibm
force-pushed
the
synch-prune-config-as-well
branch
from
c14f242 to
1f8d3de
Compare
HagarMeir
previously approved these changes
Mar 12, 2026
HagarMeir
reviewed
Mar 14, 2026
A batch of requests with a config change needs to be pruned as well, otherwise the config request and request that co-locate to the sam batch will remain in the mempool. Signed-off-by: Yoav Tock <tock@il.ibm.com>
tock-ibm
force-pushed
the
synch-prune-config-as-well
branch
from
1f8d3de to
2617d53
Compare
HagarMeir
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch of requests with a config change needs to be pruned as well, otherwise the config request and request that co-locate to the sam batch will remain in the mempool.