Skip to content

Synchronizer to prune all requests #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HagarMeir merged 1 commit into from
Mar 15, 2026
Merged

Synchronizer to prune all requests #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions node/consensus/synchronizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,17 +132,16 @@ func (s *synchronizer) Sync() smartbft_types.SyncResponse {
s.logger.Panicf("Failed parsing block we pulled: %v", err)
}

hdr := &state.Header{}
if err := hdr.Deserialize(proposal.Header); err != nil {
s.logger.Panicf("Failed deserializing header: %v", err)
}

if hdr.DecisionNumOfLastConfigBlock != hdr.Num { // not a config block
// No need to prune the genesis block, as it doesn't contain any requests. Moreover, the genesis block payload is not of type `BatchedRequests`.
if latestBlock.GetHeader().GetNumber() > 0 {
var batch arma_types.BatchedRequests
if err := batch.Deserialize(proposal.Payload); err != nil {
s.logger.Panicf("Failed deserializing proposal payload: %v", err)
}

// Prune every request in the batch from the mempool, as they are now committed.
// This is needed to prevent the mempool from growing indefinitely with requests that are already committed.
// All requests are pruned, including config requests.
for _, req := range batch {
s.pruneRequestsFromMemPool(req)
}
Expand Down
Loading