IBX-9838: FIX Edit option in three-dot menu remains clickable despite insufficient user permissions #1525
Conversation
|
| @@ -226,7 +226,7 @@ private function getLocationPermissionRestrictions(Location $location): array | |||
| 'restrictedLanguageCodes' => $createLimitationsValues[Limitation::LANGUAGE], | |||
| ], | |||
| 'edit' => [ | |||
| 'hasAccess' => $lookupUpdateLimitationsResult->hasAccess(), | |||
There was a problem hiding this comment.
Have you checked other uses of this method? If it does not work correctly, it should be fixed, or all usage should be replaced.
There was a problem hiding this comment.
I need to investigate this one, we have another variable lookupUpdateLimitationsResult thats also not working correctly here, I will come back here once I have done some test.
| return $this->permissionResolver->canUser( | ||
| 'content', | ||
| 'edit', | ||
| $content |
There was a problem hiding this comment.
Don't we need to pass any targets here as a fourth argument?
|
In |
Sztig
force-pushed
the
IBX-9838-ContentTreeController-fix
branch
from
b1b6ab3 to
27182d9
Compare
|
|
Could I get re-reviews? I have changed the implementation slightly and I wouldn't want to push it to the QA without it. |
tomaszszopinski
force-pushed
the
IBX-9838-ContentTreeController-fix
branch
from
27182d9 to
9d69b7a
Compare
|
|
merged up 8113549 |
Description:
As stated in the public ticket, when the user has a limitation, for example, only for a specific content type, lets say
Article, if we go to the Content tree, click on any other content type and open the context menu, the edit button would be clickable and it would throw a permission error.I'm fixing here the edit check to rely on
this->permissionResolver->canUserinstead ofhasAccessmethod.