Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] All pagination with filter values #1215

Conversation

IchHabRecht
Copy link
Contributor

Resolves: #1191

@IchHabRecht
Copy link
Contributor Author

Not sure how you would like the PHPStan error to be fixed. I just copied the already existing code to extend the processing of post data.

@IchHabRecht IchHabRecht force-pushed the bugfix/readd-filter-pagination-in-module branch from 2859531 to 26d0737 Compare February 18, 2025 08:00
@mschwemer
Copy link
Collaborator

mschwemer commented Feb 20, 2025

Hi 👋

For phpstan we have a baseline defined, where the code, which you copied is included.

Best thing would be to fix it in both places. ;-)
Other option would be to regenerate the baseline without the fixes.

In both cases the baseline must be regenerated.

There is a composer command in place.

composer run test:php:phpstan:generate-baseline

Thanks for your contributions. :-)

@IchHabRecht IchHabRecht force-pushed the bugfix/readd-filter-pagination-in-module branch from 26d0737 to 5288a11 Compare February 20, 2025 21:48
@IchHabRecht
Copy link
Contributor Author

Hi @mschwemer

This is the best solution I came up with

@mschwemer mschwemer merged commit a7b2d1c into in2code-de:typo3-v12 Mar 7, 2025
9 checks passed
@mschwemer
Copy link
Collaborator

@IchHabRecht Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No filtered pagination in backend module
2 participants