Skip to content

[LW-9778] Update cardano-node to 8.9.1 (via cardano-wallet) #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 4, 2024

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Jan 18, 2024

This PR updates cardano-node to 8.9.1

Todos

  • use the proper cardano-walletv2024-03-27v2024-03-01
  • turn on P2P
  • make P2P actually work
  • edit cardano-launcher/src/cardanoNode.ts to not force-bind the node to 127.0.0.1
  • revert the current patch of ↑ in node_modules in this repo

Screenshots

n/a

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus changed the title [DDW-1228] Update cardano-node to 8.7.3 (via cardano-wallet) [LW-9778] Update cardano-node to 8.7.3 (via cardano-wallet) Feb 12, 2024
Copy link
Contributor

@danielmain danielmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doskonale! 💪

Copy link
Contributor

@danielmain danielmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@michalrus michalrus changed the title [LW-9778] Update cardano-node to 8.7.3 (via cardano-wallet) [LW-9778] Update cardano-node to 8.9.1 (via cardano-wallet) Mar 26, 2024
@disassembler
Copy link
Contributor

I tested this out on mainnet. I was able to see transaction history, wallet balances, etc... Slight issue with my trezor wallet that wants to set a spending password when I open it, but I checked the previous release and it has the same problem. I have not sent any transactions or done anything that requires signing anything. My suggestion would be merge it, and rebase #3156 on it. Then finish patching that one up and do as much manual testing as we can next couple weeks and hopefully get a P2P daedalus release out in middle of April. We can also involve the community in testing the release to get more assurance there aren't any edge cases we're missing.

@danielmain danielmain merged commit c5c7ff5 into develop Apr 4, 2024
5 checks passed
@michalrus michalrus deleted the chore/ddw-1228-cardano-node-8.7.3 branch April 25, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants