fix(functions): remove pre-turbomodules implementation / fixes Expo 53 #8847
+0
−198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expo 54 appears to work if the old unused implementation still exists, however Expo 53 discovers the old implementation during autolinking and attempts to autolink it instead of the TurboModules one so functions doesn't work
Related issues
Among the regressions from react-native-firebase 23.7.0 to 23.8.0 was that functions stopped working on Expo 53
Why? As it migrated to TurboModules, the pre-TurboModules implementation was still there, and auto-linking on Expo 53 (but not 54!?) tried to link the old implementation vs the new one, and couldn't find it
So this is a fix for one of the regression in the listed issue:
Also directly fixes this issue which was opened about this exact problem while I was investigating it -
Release Summary
fix commit, so patch release via conventional commits
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
e2e tests work locally for android
I also verified using local package creation from source and a run of https://github.com/mikehardy/rnfbdemo/blob/main/make-expo-demo.sh against the local packages and Expo 53 that this works
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter