Skip to content

Conversation

@mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Jan 21, 2026

Description

Expo 54 appears to work if the old unused implementation still exists, however Expo 53 discovers the old implementation during autolinking and attempts to autolink it instead of the TurboModules one so functions doesn't work

Related issues

Among the regressions from react-native-firebase 23.7.0 to 23.8.0 was that functions stopped working on Expo 53

Why? As it migrated to TurboModules, the pre-TurboModules implementation was still there, and auto-linking on Expo 53 (but not 54!?) tried to link the old implementation vs the new one, and couldn't find it

So this is a fix for one of the regression in the listed issue:

Also directly fixes this issue which was opened about this exact problem while I was investigating it -

Release Summary

fix commit, so patch release via conventional commits

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

e2e tests work locally for android

I also verified using local package creation from source and a run of https://github.com/mikehardy/rnfbdemo/blob/main/make-expo-demo.sh against the local packages and Expo 53 that this works


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Expo 54 appears to work if the old unused implementation still exists,
however Expo 53 discovers the old implementation during autolinking and
attempts to autolink it instead of the TurboModules one so functions
doesn't work
@vercel
Copy link

vercel bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
react-native-firebase Ready Ready Preview, Comment Jan 21, 2026 4:40pm

Request Review

@mikehardy
Copy link
Collaborator Author

This was Android only and that e2e test has already passed CI, merging

@mikehardy mikehardy merged commit 81e992c into main Jan 21, 2026
21 of 23 checks passed
@mikehardy mikehardy deleted the @mikehardy/functions-turbomodules-android-packagename-fix branch January 21, 2026 17:20
@mikehardy mikehardy changed the title fix(functions): remove pre-turbomodules implementation fix(functions): remove pre-turbomodules implementation / fixes Expo 53 Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛] 🔥 @react-native-firebase/functions@23.8.3 does not seem to be linked properly natively

3 participants