[DT][GPU] Implement EncodingLayoutResolverAttrInterface for GPUEncodingLayoutAttr. #20027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
requested review from
bjacob,
hanhanW,
antiagainst,
qedawkins,
MaheshRavishankar and
benvanik
as code owners
jtuyls
commented
Feb 19, 2025
hanhanW
requested changes
Feb 19, 2025
compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingInterfaces.td
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/Stream/Transforms/SpecializeEncodings.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/Stream/Transforms/test/specialize_encodings.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/Stream/Transforms/test/specialize_encodings.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/Stream/Transforms/test/specialize_encodings.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/ExternalInterfaces/GPUEncodingExternalModels.cpp
Outdated
Show resolved
Hide resolved
jtuyls
force-pushed
the
impl-layout-attr-interface
branch
2 times, most recently
from
d88b61c to
4eb88b9
Compare
jtuyls
commented
Feb 19, 2025
compiler/src/iree/compiler/Codegen/Common/MaterializeEncoding.cpp
Outdated
Show resolved
Hide resolved
hanhanW
reviewed
Feb 19, 2025
compiler/src/iree/compiler/Codegen/ExternalInterfaces/GPUEncodingExternalModels.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/ExternalInterfaces/GPUEncodingExternalModels.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/Stream/Transforms/test/specialize_encodings.mlir
Outdated
Show resolved
Hide resolved
hanhanW
changed the title
jtuyls
force-pushed
the
impl-layout-attr-interface
branch
from
4eb88b9 to
2c6a819
Compare
hanhanW
reviewed
Feb 20, 2025
jtuyls
force-pushed
the
impl-layout-attr-interface
branch
from
2c6a819 to
7116165
Compare
hanhanW
reviewed
Feb 20, 2025
jtuyls
force-pushed
the
impl-layout-attr-interface
branch
from
7116165 to
0447670
Compare
hanhanW
reviewed
Feb 20, 2025
compiler/src/iree/compiler/Codegen/Common/MaterializeEncoding.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/Stream/Transforms/test/specialize_encodings.mlir
Outdated
Show resolved
Hide resolved
jtuyls
changed the title
hanhanW
reviewed
Feb 20, 2025
compiler/src/iree/compiler/Dialect/Stream/Transforms/test/specialize_encodings.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/test/gpu_materialize_encoding_gfx942.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/test/gpu_materialize_encoding_gfx942.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/test/gpu_materialize_encoding_gfx942.mlir
Show resolved
Hide resolved
jtuyls
force-pushed
the
impl-layout-attr-interface
branch
from
0447670 to
4f00a07
Compare
Signed-off-by: Jorn Tuyls <[email protected]>
jtuyls
force-pushed
the
impl-layout-attr-interface
branch
from
4f00a07 to
b6a0d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the EncodingLayoutAttrInterface (
cloneWithSimplifiedConfigandgetLayoutmethods) for GPU.This replaces the
targetAttrfield inGPUEncodingLayoutAttrwith a dictionary for storing the serialized encoding info.This PR also removes an unused /unneeded
encoding = #iree_cpu.cpu_encoding_layout<>attribute from the llvmcpu encoding materialization tests which leads to confusion on what this does.I will implement the SerializedEncodingLayoutAttrInterface in a separate PR.