Skip to content

Adds custom asset handling to external template generation #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

louislelay
Copy link
Contributor

@louislelay louislelay commented Apr 15, 2025

Description

The external template generator didn’t originally account for adding personal assets, but it just felt right to include this — it’s cleaner and more intuitive for users to keep everything in one place when needed.

This PR adds that option. During project generation, the script now asks whether the user plans to use a custom asset. If so, it sets up the necessary directory structure under data/, copies in relevant example files (like the Cartpole USD and its config), and modifies the asset configuration files accordingly. Since the Cartpole environment is already used throughout the generator as a reference, I kept building on that as the base when a custom setup is requested.

I also removed the .usd restriction from the .gitignore in external projects, since it doesn’t make sense to forbid tracked USDs when the user explicitly wants to include them.

One thing I’m not totally happy with is that to download the assets, I hardcoded this URL:

ISAACLAB_NUCLEUS_DIR = "http://omniverse-content-production.s3-us-west-2.amazonaws.com/Assets/Isaac/4.5/Isaac/IsaacLab"

I didn’t want to do import ISAACLAB_NUCLEUS_DIR from isaaclab.utils.assets just to avoid spinning up the app during generation. If there’s a better way to handle this, I’m open to suggestions!

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant