Adds gnureadline to base docker image#4017
Closed
bmccann-bdai wants to merge 2 commits into
Closed
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR adds the
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant DockerBuild as Docker Build Process
participant BaseImage as Isaac Sim Base Image
participant IsaacLabSetup as Isaac Lab Setup
participant PipInstall as pip install
participant REPL as Python REPL
DockerBuild->>BaseImage: FROM isaac-sim base image
DockerBuild->>IsaacLabSetup: Copy Isaac Lab files
DockerBuild->>IsaacLabSetup: Set execute permissions on isaaclab.sh
DockerBuild->>IsaacLabSetup: Create symlink to Isaac Sim
DockerBuild->>PipInstall: isaaclab.sh -p -m pip install toml gnureadline
PipInstall->>PipInstall: Install toml package
PipInstall->>PipInstall: Install gnureadline package
PipInstall-->>IsaacLabSetup: Dependencies installed
DockerBuild->>IsaacLabSetup: Install extension apt dependencies
DockerBuild->>IsaacLabSetup: Create directories for singularity
DockerBuild->>IsaacLabSetup: Install Isaac Lab dependencies
DockerBuild->>IsaacLabSetup: Configure bash aliases
Note over REPL: gnureadline enables proper<br/>arrow key handling in Python REPL
|
Mayankm96
reviewed
Nov 19, 2025
Contributor
Mayankm96
left a comment
There was a problem hiding this comment.
Do we need to add license for this dependency?
Collaborator
Author
I just want it as a dependency for the python REPL. I don't intend to build code against it. If it's a problem, I can just install it locally. |
Contributor
|
Generally, we need permissive licenses for all the dependencies we install in the docker. gnureadline looks like is GPL license, so I think it's best to avoid it if we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add gnureadline to the base image. Fix up arrow capture in the python REPL.