Fixed issue user leg terminating immediately even if we specify JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS#1246
Open
rammohan-y wants to merge 12 commits intojambonz:mainfrom
Open
Fixed issue user leg terminating immediately even if we specify JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS#1246rammohan-y wants to merge 12 commits intojambonz:mainfrom
rammohan-y wants to merge 12 commits intojambonz:mainfrom
Conversation
…o wait is not executing Also, added logic of waiting in create-call when a call is created using rest jambonz#997
Contributor
|
@xquanluu @davehorton there were case which was not handle like restDial and there was bug in Dial with transcribe verb which has been fixed, also we have tested it, please review it |
xquanluu
reviewed
Jun 17, 2025
| ...req.body | ||
| }; | ||
|
|
||
| const origDestroy = ep.destroy.bind(ep); |
Contributor
There was a problem hiding this comment.
can you create a function that has ep as input that do this modification of destroy function.
as create call will have ep and dualEp (in another scenario)
Contributor
Author
There was a problem hiding this comment.
@xquanluu Additional to your suggestion above I had centralized the overriding the destroy and stopTranscription in an helper method and calling it from everywhere
…using it across Also, along with destroy we need to delay the stopTranscription to allow transcription to reach from freeswitch to feature server
…nscription should be called immediately
Contributor
|
@xquanluu @davehorton can you review this fix |
Contributor
Author
|
@davehorton please review this when you get some time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue of user leg terminating immediately even if we specify JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS
Also, added logic of waiting in create-call when a call is created using rest
#997
@xquanluu @vdharashive @davehorton @sammachin