subscriber: apply envfilter's target filter to events as well as spans #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following a conversation on Discord, I learnt that an EnvFilter
constructed like this:
enables the
debuglevel for any event emitted within the context ofspan.It would be ideal if the
debuglevel were consistently applied toevents as well as spans. This would mean that the
target=debugfilterwould also be applied to events generated within the context of the
span.
Solution
Add a new field inside CallsiteMatcher to keep track of the most
specific target match among Directives that match a callsite Metadata.
Open questions:
Stringis needed. Unsure if there is away to avoid it?
we should do in cases where there's a conflict between the maximum
level and the most specific target match: