Conversation
| "cli-color": "^2.0.3", | ||
| "deepmerge": "^4.2.2", | ||
| "esbuild": "^0.19.2", | ||
| "esbuild": "^0.25.3", |
There was a problem hiding this comment.
can you also move it to devDependencies? that will avoid this from being a problem in the future and avoid people from downloading it in the first place
There was a problem hiding this comment.
If the maintainer expresses interest in merging it then I'll make any additional changes but if it's not going to get merged I'll hold off on any continued changes 😅
There was a problem hiding this comment.
well if you have to wait a couple of months for him to come tell you that he wants it changed and then you have to wait a couple of months more for the actual merge then you're just prolonging things. seems better to do it now and allow it to be merged more quickly when it's gotten around to
There was a problem hiding this comment.
I've sent an improved fix if you'd like to close this one: #270
Before submitting the PR, please make sure you do the following
Bumps esbuild to the latest version to fix the vulnerability warning
Closes #264
npm run lint!)Cannot run "npm run lint" as I don't have the right typescript version (What I understand from the error message) so it just crashes. But changes are minor enough that I don't think I could have failed any lints unless they were already failing.
Tests
npm testoryarn testFixed up one of the tests in utils.test.ts which was failing from a type error. Other than that all tests are passing