Skip to content

fix: bump esbuild #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacobtread wants to merge 2 commits into from
Closed

fix: bump esbuild #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1d5ce
fix: bump esbuild version
jacobtread Apr 28, 2025
bd30099
fix: type checking for window location failing
jacobtread Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"dependencies": {
"cli-color": "^2.0.3",
"deepmerge": "^4.2.2",
"esbuild": "^0.19.2",
"esbuild": "^0.25.3",
Copy link

@benmccann benmccann May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also move it to devDependencies? that will avoid this from being a problem in the future and avoid people from downloading it in the first place

Copy link
Author

@jacobtread jacobtread May 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the maintainer expresses interest in merging it then I'll make any additional changes but if it's not going to get merged I'll hold off on any continued changes 😅

Copy link

@benmccann benmccann May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well if you have to wait a couple of months for him to come tell you that he wants it changed and then you have to wait a couple of months more for the actual merge then you're just prolonging things. seems better to do it now and allow it to be merged more quickly when it's gotten around to

Copy link

@benmccann benmccann May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent an improved fix if you'd like to close this one: #270

"estree-walker": "^2",
"intl-messageformat": "^10.5.3",
"sade": "^1.8.1",
Expand Down
Loading