-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[MBL-2924] Design Polish - Navigation Buttons #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[MBL-2924] Design Polish - Navigation Buttons #2680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we do write new code in SwiftUI, our team standards are to move views over at the level of an entire feature or entire screen. Because this is a single button in an existing UIKit view, it should be written in UIKit.
I would also recommend moving the glassedEffect into its own helper file, since it looks like you'll be using it in more than one place.
| @@ -1,8 +1,10 @@ | |||
| import Combine | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see Combine being used, this import should be deleted.
| |> UIButton.lens.accessibilityHint %~ { _ in Strings.Closes_project() } | ||
|
|
||
| return buttonView | ||
| private lazy var closeButtonHostingController: UIHostingController<CloseButtonView> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view is very small. Because it is a small component of a UIKit view, it should be written in UIKit.
… in the original UIKit file
📲 What
We are updating the close button in the navigation to standardize the visual experience and ensure that the application has a polished look.
🤔 Why
The styles of the navigation buttons have been adjusted to ensure visual consistency. The appearance has been updated to make the component look integrated.
🛠 How
👀 See
| Before 🐛 | After 🦋 |
|
|
|
✅ Acceptance criteria