-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[MBL-2924] Design Polish - Navigation Buttons #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fernandacerezog
wants to merge
4
commits into
main
Choose a base branch
from
feat/fercerezo/MBL-2924/UpdateNavigationButtons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+101
−16
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+4.22 KB
(220%)
...ectPageNavigationBarViewTests/testNavigationBar_Unwatched_Success.unwatched.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.32 KB
(240%)
...ProjectPageNavigationBarViewTests/testNavigationBar_Watched_Success.watched.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions
24
Kickstarter-iOS/SharedViews/SwiftUIHelpers/CloseButtonView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import KDS | ||
| import Library | ||
| import SwiftUI | ||
|
|
||
| /// A SwiftUI close button with liquid glass effect. | ||
| /// | ||
| /// This view is designed to be used within UIKit views via UIHostingController. | ||
| struct CloseButtonView: View { | ||
| let onClose: () -> Void | ||
|
|
||
| var body: some View { | ||
| Button(action: self.onClose) { | ||
| Image(uiImage: image(named: "icon--cross") ?? UIImage()) | ||
| .renderingMode(.template) | ||
| .foregroundColor(Color(LegacyColors.ksr_support_700.uiColor())) | ||
| .frame(width: 20, height: 20) | ||
| } | ||
| .frame(width: 44, height: 44) | ||
| .contentShape(Circle()) | ||
| .glassedEffect(in: Circle(), interactive: true) | ||
| .accessibilityLabel(Strings.accessibility_projects_buttons_close()) | ||
| .accessibilityHint(Strings.Closes_project()) | ||
| } | ||
| } |
42 changes: 42 additions & 0 deletions
42
Kickstarter-iOS/SharedViews/SwiftUIHelpers/GlassEffect.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import SwiftUI | ||
|
|
||
| extension View { | ||
| /// Applies a glass/liquid glass effect to a view within a shape. | ||
| /// - Parameters: | ||
| /// - shape: The shape to apply the glass effect within | ||
| /// - interactive: Whether the effect should be interactive (iOS 26+) | ||
| /// - Returns: A view with the glass effect applied | ||
| @ViewBuilder | ||
| func glassedEffect(in shape: some Shape, interactive: Bool = false) -> some View { | ||
| if #available(iOS 26.0, *) { | ||
| self.glassEffect(interactive ? .regular.interactive() : .regular, in: shape) | ||
| } else { | ||
| self.background { | ||
| shape.glassed() | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension Shape { | ||
| /// Creates a glass-like effect fallback for iOS < 26 | ||
| fileprivate func glassed() -> some View { | ||
| self | ||
| .fill(.ultraThinMaterial) | ||
| .fill( | ||
| .linearGradient( | ||
| colors: [ | ||
| .primary.opacity(0.08), | ||
| .primary.opacity(0.05), | ||
| .primary.opacity(0.01), | ||
| .clear, | ||
| .clear, | ||
| .clear | ||
| ], | ||
| startPoint: .topLeading, | ||
| endPoint: .bottomTrailing | ||
| ) | ||
| ) | ||
| .stroke(.primary.opacity(0.2), lineWidth: 0.7) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view is very small. Because it is a small component of a UIKit view, it should be written in UIKit.