ENH: add full_like #174
Merged
ENH: add full_like #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `full_like` creation function and turn the matching array API standard test on in the CI
* `isnan()` already existed, but was not passing the API standard test, so it has been adjusted to pass the test, which is now enforced in CI
* adjust the `equal()` ufunc to pass its array API standard test, and turn this test on in the CI * the changes include improved broadcasting and (type) casting support * because equality testing is so common/rampant, this required a few more shims than I'd like...
NaderAlAwar
approved these changes
Feb 22, 2023
Contributor
Author
tylerjereddy
added a commit
to tylerjereddy/pykokkos
that referenced
this pull request
Mar 1, 2023
* bring `positive()` ufunc up to API standard and turn its test on in the CI; since `positive()` essentially returns a copy view, this can be done fairly simply it seems, though I do wonder if we need to do it differently on GPU (conversely, view assignment in Python should probably just happen naturally depending on default execution space, though I kind of doubt it at the moment) * also required shims to `__eq__` for `Subview`, basically copying the implementation used for regular `View` * an adjustment to `equal()` ufunc was needed to correctly handle two size-0 views it seems * I had to add `test_isnan` and `test_equal` to the CI API standard testing as well because of kokkos#174 (comment) (I'm modifying those ufuncs here and need to make sure their tests still pass...) * I needed to make some weird change to `_typematch_views` -- if you find a way to avoid that, by all means push it in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full_likecreation function and turn its array API standard test on in the CIfull_likeyet--feel free to help me get that in by adapting from https://data-apis.org/array-api/latest/API_specification/generated/array_api.full_like.html?highlight=full_like