Add support for Kokkos::complex #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gliga
approved these changes
Oct 14, 2024
Contributor
gliga
left a comment
gliga
left a comment
There was a problem hiding this comment.
good but CI seems to be complaining
Closed
Collaborator
|
Need to merge kokkos/pykokkos-base#61 before checking this, as Nader said. |
Collaborator
|
@IvanGrigorik it looks like kokkos/pykokkos-base has been merged, has the CI been rerun? |
Collaborator
JBludau
reviewed
Nov 18, 2025
JBludau
approved these changes
Nov 18, 2025
Contributor
JBludau
left a comment
JBludau
left a comment
There was a problem hiding this comment.
Apart from the naming discussion, I think this is ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
Kokkos::complex<float>andKokkos::complex<double>while also providing interoperability with Python's and NumPy's complex numbers. It requires PR kokkos/pykokkos-base#61.