modify atomic functions #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@IvanGrigorik I would like to add you as a reviewer, but since I'm not part of the author group, I can only tag you |
IvanGrigorik
requested changes
Dec 25, 2025
Collaborator
IvanGrigorik
left a comment
IvanGrigorik
left a comment
There was a problem hiding this comment.
All good except formatting issue
No camelCase in Python, use snake_case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change atomic_fetch_min, atomic_fetch_max to return old result, same as thrust library
implement atomic_compare_exchange