Skip to content

modify atomic functions #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IvanGrigorik merged 3 commits into from
Dec 25, 2025
Merged

modify atomic functions #334

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff819ec
modify atomic functions
Wilson1211 Dec 24, 2025
6123d96
change camelCase to snake_case
Wilson1211 Dec 25, 2025
e22e89a
Merge branch 'kokkos:main' into main
Wilson1211 Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pykokkos/interface/atomic/atomic_fetch_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,20 @@ def atomic_fetch_max(
view: View,
indices: List[int],
value: Union[int, float]) -> Union[int, float]:
oldResult: int = view[indices[-1]]
inner = reduce(operator.getitem, indices[:-1], view)
inner[indices[-1]] = max(inner[indices[-1]], value)
return inner[indices[-1]]
return oldResult

def atomic_fetch_min(
view: View,
indices: List[int],
value: Union[int, float]) -> Union[int, float]:
oldResult: int = view[indices[-1]]
inner = reduce(operator.getitem, indices[:-1], view)
inner[indices[-1]] = min(inner[indices[-1]], value)
return inner[indices[-1]]
return oldResult
# return inner[indices[-1]]

def atomic_fetch_mod(
view: View,
Expand Down Expand Up @@ -110,4 +113,8 @@ def atomic_compare_exchange(
indices: List[int],
comparison_value: int,
new_value: int) -> int:
pass
inner = reduce(operator.getitem, indices[:-1], view)
oldResult = inner[indices[-1]]
if oldResult == comparison_value:
inner[indices[-1]] = new_value
return oldResult