-
Notifications
You must be signed in to change notification settings - Fork 83
Prepare for v0.20 #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Prepare for v0.20 #417
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomasaschan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
96c875e
to
cacef1f
Compare
This LGTM other than the test failing. I sent kubernetes/org#5563 which should be the required permissions. |
This is to match the current client-go version according to https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/docs/project-management/branching-and-versioning.md
458fe87
to
d60174a
Compare
e00ac9c
to
9b8cc00
Compare
@justinsb I tried to bump the How do I clear that out? |
Ah, sorry about the kubectl version... I updated it as part of #418. I just cherry-picked it as a standalone PR (#421) also, though I suspect it might rely on #418 because of the switch to use envtest (because I think newer kubectl uses the newer discovery mechanisms, not yet implemented in mock-kubeapiserver). Direction for mock-kubeapiserver is TBD, I was enthusiastic about it in the past, now I'm feeling that we should focus our efforts on just improving kube-apiserver ... much harder, but a much bigger payoff (envtest uses "real" kube-apiserver.) |
Sequencing of all of this is a bit unclear to me. Are you suggesting we do #421 before tagging a new version? Or after? |
So in theory we can do it all at once now. Because this PR updates TAG_VERSION, it should get tagged with that version after merge. Because the version is beta.1 we will also create a new release branch at that point. I guess in general therefore that we should update kubectl alongside the TAG_VERSION to beta.1 (although maybe we a minor lag or two?) We haven't been fully disciplined about this previously, so I think we will likely have some PRs that would ideally be smaller while we figure this out. e.g. maybe we bump kubectl during the alpha (before cutting a branch,) but really that only works if we had a previous release branch. This LGTM, as long as we can get the tests to pass. And seeing as they are I am going to lgtm (after I check whether TAG_VERSION expects a |
Tests passed locally when I had |
💥 |
This bumps
sigs.k8s.io/controller-runtime
to v0.20.x andk8s.io/client-go
to v0.32.x according to our release versioning docs.Next steps after this is merged, is to
release-v0.20
branch from latest masterv0.20.0-beta.1
tagv0.20.0
release@justinsb or @atoato88 Could you, when you have the time, add me as an admin on the repo here on Github, so I gain access to do things like push tags, branches and releases? Currently I don't have that, so I can't really do any of the automated stuff related to releasing new versions.
Closes #421.