Skip to content

Prepare for v0.20 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tomasaschan
Copy link
Member

@tomasaschan tomasaschan commented Apr 2, 2025

This bumps sigs.k8s.io/controller-runtime to v0.20.x and k8s.io/client-go to v0.32.x according to our release versioning docs.

Next steps after this is merged, is to

  • Create a release-v0.20 branch from latest master
  • Create a v0.20.0-beta.1 tag
  • Start drafting release notes for the v0.20.0 release

@justinsb or @atoato88 Could you, when you have the time, add me as an admin on the repo here on Github, so I gain access to do things like push tags, branches and releases? Currently I don't have that, so I can't really do any of the automated stuff related to releasing new versions.

Closes #421.

Sorry, something went wrong.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from atoato88 April 2, 2025 08:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomasaschan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from justinsb April 2, 2025 08:52
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2025
@tomasaschan tomasaschan force-pushed the release-v0.20-prep-work branch from 96c875e to cacef1f Compare April 2, 2025 08:54
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@justinsb
Copy link
Contributor

This LGTM other than the test failing.

I sent kubernetes/org#5563 which should be the required permissions.

Verified

This commit was signed with the committer’s verified signature.
tomasaschan Tomas Aschan

Verified

This commit was signed with the committer’s verified signature.
tomasaschan Tomas Aschan
@tomasaschan tomasaschan force-pushed the release-v0.20-prep-work branch from 458fe87 to d60174a Compare April 28, 2025 07:38
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2025

Verified

This commit was signed with the committer’s verified signature.
tomasaschan Tomas Aschan

Verified

This commit was signed with the committer’s verified signature.
tomasaschan Tomas Aschan

Verified

This commit was signed with the committer’s verified signature.
tomasaschan Tomas Aschan
@tomasaschan tomasaschan force-pushed the release-v0.20-prep-work branch from e00ac9c to 9b8cc00 Compare April 28, 2025 08:46
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 28, 2025

Verified

This commit was signed with the committer’s verified signature.
tomasaschan Tomas Aschan
@tomasaschan
Copy link
Member Author

@justinsb I tried to bump the kubectl version used in the tests, but prow seems to have a cached one (on 1.27, according to logs) which makes the updated API server intereaction expectations invalid.

How do I clear that out?

@justinsb
Copy link
Contributor

Ah, sorry about the kubectl version... I updated it as part of #418. I just cherry-picked it as a standalone PR (#421) also, though I suspect it might rely on #418 because of the switch to use envtest (because I think newer kubectl uses the newer discovery mechanisms, not yet implemented in mock-kubeapiserver).

Direction for mock-kubeapiserver is TBD, I was enthusiastic about it in the past, now I'm feeling that we should focus our efforts on just improving kube-apiserver ... much harder, but a much bigger payoff (envtest uses "real" kube-apiserver.)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tomasaschan
Copy link
Member Author

Sequencing of all of this is a bit unclear to me. Are you suggesting we do #421 before tagging a new version? Or after?

@justinsb
Copy link
Contributor

Sequencing of all of this is a bit unclear to me. Are you suggesting we do #421 before tagging a new version? Or after?

So in theory we can do it all at once now. Because this PR updates TAG_VERSION, it should get tagged with that version after merge. Because the version is beta.1 we will also create a new release branch at that point.

I guess in general therefore that we should update kubectl alongside the TAG_VERSION to beta.1 (although maybe we a minor lag or two?)

We haven't been fully disciplined about this previously, so I think we will likely have some PRs that would ideally be smaller while we figure this out. e.g. maybe we bump kubectl during the alpha (before cutting a branch,) but really that only works if we had a previous release branch.

This LGTM, as long as we can get the tests to pass. And seeing as they are I am going to lgtm (after I check whether TAG_VERSION expects a v prefix or not)!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tomasaschan
Copy link
Member Author

This LGTM, as long as we can get the tests to pass.

Tests passed locally when I had [email protected], so I'm pretty confident they will pass now - at least assuming this was enough to make the test runner also use that version :)

@tomasaschan
Copy link
Member Author

💥

@tomasaschan tomasaschan requested a review from justinsb April 28, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants