chore: update version of kubectl used in tests #421
Conversation
We want to use newer kubectl versions in general. This version is also helpful for golden tests because it prefers json over protobuf.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/M
There was a problem hiding this comment.
/lgtm
but we might bundle this in #417 since I guess it makes sense to use a version of kubectl that matches the version of client-go.
| @@ -31,7 +31,7 @@ REPO_ROOT=$(pwd) | |||
| if [[ ! -f "bin/kubectl" ]]; then | |||
| echo "Downloading kubectl to bin/kubectl" | |||
| mkdir -p bin/ | |||
| curl -L -o bin/kubectl https://dl.k8s.io/release/v1.27.0/bin/linux/amd64/kubectl | |||
| curl -L -o bin/kubectl https://dl.k8s.io/release/v1.32.1/bin/linux/amd64/kubectl | |||
There was a problem hiding this comment.
Ah, this (or rather not doing this) is why my attempts at this in #417 kept failing.
|
Definitely in favor of bundling these into fewer PRs (and #417 in particular). I split them up usually so that I can figure out what fails if we only do half of a bigger PR :-) |
We want to use newer kubectl versions in general.
This version is also helpful for golden tests because it prefers json over protobuf.