feat(l1): allow overriding RocksDB config #4728
Draft
+14
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
- (!) Patches temporarily (do not merge!) the RocksDB dep to a personal repo containing a feature I sent upstream that exposes a function needed for this feature; - Introduces a new `ETHREX_ROCKSDB_OPTIONS_OVERRIDE` environment variable to allow for faster testing of different settings. The syntax is described in the following [blogpost](https://rocksdb.org/blog/2015/02/24/reading-rocksdb-options-from-a-file.html). A user or developer should set this variable with the appropriate text. For convenience, we might want to store the settings in a file. It can be loaded by running: ```sh export ETHREX_ROCKSDB_OPTIONS_OVERRIDE=$(cat example.conf) ```
Oppen
force-pushed
the
feat/rocksdb_config_file
branch
from
ce6daa3 to
44d51d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #issue_number